[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-30 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-955168639 Could someone trigger the tests workflow further, please? Should be green now -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-28 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-953569881 The function `normalize_directory_path` was moved to stay inside `google` provider package, in order to stay compatible with Airflow 2.1. -- This is an automated message f

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-26 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-951776824 > @eskarimov You cannot create new methods in the Airflow core as we are trying to maintain backward compatibility with Airflow 2.1. Ah, I see, thanks @mik-laj. I'

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-25 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-951157425 Sorry for bothering, just wanted to check if I could do anything additional on the PR in order to get it merged -- This is an automated message from the Apache Git Service

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-19 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-946657445 @uranusjr thank you so much for triggering the tests - I've missed the static code checks unfortunately, so I had to fix failed checks (and also properly setup pre-commit ho

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-18 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-945894875 I had to make small changes in the most recent commit, as described in the following issue #14682, validation/normalisation of input parameters, which could be templated, s

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-09-29 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-930156422 > I think that the docstring on CloudDataTransferServiceS3ToGCSOperator will have to be updated to reflect these changes: > > https://github.com/eskarimov/airflow/blo

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-09-29 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-930156422 > I think that the docstring on CloudDataTransferServiceS3ToGCSOperator will have to be updated to reflect these changes: > > https://github.com/eskarimov/airflow/blo