feluelle commented on a change in pull request #9195:
URL: https://github.com/apache/airflow/pull/9195#discussion_r437508400
##########
File path: .pre-commit-config.yaml
##########
@@ -159,15 +159,23 @@ metastore_browser/templates/.*\\.html$|.*\\.jinja2"
hooks:
- id: rst-backticks
- id: python-no-log-warn
- - repo: local
+ - repo: https://github.com/adrienverge/yamllint
+ rev: v1.23.0
Review comment:
Fix version - I set it to the latest version.
##########
File path: .pre-commit-config.yaml
##########
@@ -141,7 +141,7 @@ metastore_browser/templates/.*\\.html$|.*\\.jinja2"
hooks:
- id: check-hooks-apply
- repo: https://github.com/pre-commit/pre-commit-hooks
- rev: v2.5.0
+ rev: v3.1.0
Review comment:
> pre-commit/pre-commit-hooks now requires python3.6.1+
That is the only noticeable difference for us.
Ref: https://github.com/pre-commit/pre-commit-hooks/releases
##########
File path: .pre-commit-config.yaml
##########
@@ -159,15 +159,23 @@ metastore_browser/templates/.*\\.html$|.*\\.jinja2"
hooks:
- id: rst-backticks
- id: python-no-log-warn
- - repo: local
+ - repo: https://github.com/adrienverge/yamllint
+ rev: v1.23.0
hooks:
- id: yamllint
name: Check yaml files with yamllint
entry: yamllint -c yamllint-config.yml
- language: python
- additional_dependencies: ['yamllint']
types: [yaml]
exclude: ^.*init_git_sync\.template\.yaml$|^.*airflow\.template\.yaml$
+ - repo: https://github.com/timothycrosley/isort
+ rev: 4.3.21-2
Review comment:
Fix version - I set it to the latest version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
