[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-04-05 Thread via GitHub
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1497582851 The issues should all be resolved. I know that it does not look so great using string replacements, but I think it is safe to use it in these cases. -- This is an automated message f

[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-02-17 Thread via GitHub
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1435148046 Actually, I have found some issues. Will hopefully resolve them on Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-01-31 Thread via GitHub
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1411582283 Yes, good catch @ashb and @josh-fell thank you for the heads-up. That is a tricky one. I would say we merge the other PR first and I will just update my PR and docs to reflect the chan

[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-01-24 Thread via GitHub
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-140186 I have added [Add missing uri and add file protocol](https://github.com/apache/airflow/pull/28721/commits/e383957ab3e77e1813211ad2bc4f17ae6a65813e) and [Fix sqlite hook tests](https:/

[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-01-04 Thread GitBox
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1370967740 I have found a solution https://github.com/apache/airflow/pull/28721/commits/f3eaec7875fc7bc373069320cf72d5852dbbc812 which does not require the conn_type to be added on user side. PT

[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-01-04 Thread GitBox
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1370717908 Note to reviewers: This is a breaking change as it requires the `conn_type` attribute to be specified in a Sqlite Connection. -- This is an automated message from the Apache Git Serv