ferruzzi commented on code in PR #32591: URL: https://github.com/apache/airflow/pull/32591#discussion_r1263069030
########## airflow/utils/log/logging_mixin.py: ########## @@ -174,15 +172,18 @@ def flush(self): def isatty(self): """ Returns False to indicate the fd is not connected to a tty(-like) device. + For compatibility reasons. """ return False class RedirectStdHandler(StreamHandler): """ + # TODO D205-ify this docstring Review Comment: Advice? ########## airflow/utils/operator_helpers.py: ########## @@ -199,6 +199,8 @@ def determine_kwargs( def make_kwargs_callable(func: Callable[..., R]) -> Callable[..., R]: """ + # TODO: D205-ify this one Review Comment: Advice? ########## airflow/utils/task_group.py: ########## @@ -398,6 +389,8 @@ def child_id(self, label): @property def upstream_join_id(self) -> str: """ + # TODO: D205-ify this one Review Comment: Advice? ########## airflow/utils/task_group.py: ########## @@ -407,6 +400,8 @@ def upstream_join_id(self) -> str: @property def downstream_join_id(self) -> str: """ + # TODO: D205-ify this one Review Comment: Advice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org