flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-939052887
@potiuk done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-931708300
@potiuk done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-928259116
@potiuk Tests fails :( whats wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-928259116
@potiuk Tests fails :( whats wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-927196352
@uranusjr @potiuk Hi, i did some changes in the code for addressing last
review.
1) Made a static method for the splitting part (better testing)
2) Default strip ; after
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-893071375
> sqlparse is not a core dependency -- it needs adding.
Hi @ashb, what do you mean with "it needs adding"? I added sqlparse to
setup.cfg. We need to do anything else?
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-893071375
> sqlparse is not a core dependency -- it needs adding.
Hi @ashb, what do you mean with "it needs adding"? I added sqlparse to
setup.cfg. We need to do anything else?
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-892050301
@uranusjr @potiuk Okay, I think that defaulting True for split_statement
sounds good, bc if someone has some edge-cases (sqlparse is not perfect) can be
easily fixed changing
flolas commented on pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#issuecomment-891368646
> Some static checks are failing
fix'd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
