galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-477121561
Thanks for merging it! Big thanks for support and help for @FlyrInc !
-
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-476785413
@ashb I agree, I just take literally what @dimberman that he would like this
as `private` helper, which I took
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-476773177
For me `__` always meant private (because it cannot be overwritten), and
`_` protected (because it can be over
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-476763348
@ashb I've rebase Your changes.
This is an aut
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-476536857
@ashb @dimberman hope now it's good to go! I've applied requested changes.
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-474695251
@ashb can I understand reasoning behind that, why we want to test that now?
None of the tests were testing outp
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-474595681
@ashb I've applied Your feedback, and made unittest mocked rather than
calling k8s and checking values back
--
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-473890890
@ashb @feng-tao kindly request, please review this again. Is there still any
concern there? I've applied all th
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-472530565
@ashb I've incorporated Your feedback. Hope it's good now. ;)
-
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-471677578
@ashb @feng-tao @pgagnon another round of changes from code review applied.
Please review.
---
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-469779659
@feng-tao @ashb @pgagnon this PR is ready for review, I've incorporated most
of the requested changes here. Tes
11 matches
Mail list logo
