[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-14 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r873084202 ## chart/templates/dagprocessor/dag-processor-deployment.yaml: ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-14 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r873084230 ## chart/templates/dagprocessor/dag-processor-serviceaccount.yaml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-14 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r873084314 ## chart/values.schema.json: ## @@ -2101,6 +2102,264 @@ } } }, +"dagProcessor": { Review Comment: This block is bas

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-14 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r873084453 ## chart/templates/_helpers.yaml: ## @@ -653,6 +664,14 @@ Create the name of the cleanup service account to use airflow jobs check --job-type TriggererJob --host

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-14 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r873084559 ## tests/charts/test_basic_helm_chart.py: ## @@ -97,6 +97,78 @@ def test_basic_deployments(self): "TEST-LABEL" ), f"Missing label TEST-L

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-14 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r873084653 ## tests/charts/test_dag_processor.py: ## @@ -0,0 +1,431 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-16 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r874055316 ## chart/templates/dagprocessor/dag-processor-deployment.yaml: ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-05-17 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r874774863 ## chart/templates/_helpers.yaml: ## @@ -653,6 +664,14 @@ Create the name of the cleanup service account to use airflow jobs check --job-type TriggererJob --host

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-07-05 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r914215373 ## chart/templates/scheduler/scheduler-deployment.yaml: ## @@ -141,7 +141,7 @@ spec: {{- include "custom_airflow_environment" . | indent 10 }} {

[GitHub] [airflow] gmsantos commented on a diff in pull request #23711: Helmchart: Provision Standalone Dag Processor

2022-07-05 Thread GitBox
gmsantos commented on code in PR #23711: URL: https://github.com/apache/airflow/pull/23711#discussion_r914256938 ## tests/charts/test_basic_helm_chart.py: ## @@ -113,6 +113,84 @@ def test_basic_deployments(self, version): "TEST-LABEL" ), f"Missing l