houqp edited a comment on issue #7503: [AIRFLOW-3607] fixed the bug with picking just special cases while maintaining the p… URL: https://github.com/apache/airflow/pull/7503#issuecomment-607457730 This change looks correct to me. In my original fix, I also added unit tests to prevent regressions and looks like those tests are still passing, so we should be good 👍 `_get_ready_tis` also has a stricter depContext, so it should yield a more correct scheduling behavior. That said, @amichai07 are you sure your patch actually results in performance improvement? Looking at the code, `_get_ready_tis` actually does more work than the else branch being replaced. I don't think this is a blocker, but just curious if I missed anything in the code. If it's a refactor without performance gain, we should change the commit message accordingly.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
