hussein-awala commented on code in PR #29606:
URL: https://github.com/apache/airflow/pull/29606#discussion_r1111270818
##########
airflow/triggers/temporal.py:
##########
@@ -41,10 +41,8 @@ def __init__(self, moment: datetime.datetime):
# Make sure it's in UTC
elif moment.tzinfo is None:
raise ValueError("You cannot pass naive datetimes")
- elif not hasattr(moment.tzinfo, "offset") or moment.tzinfo.offset !=
0: # type: ignore
- raise ValueError(f"The passed datetime must be using Pendulum's
UTC, not {moment.tzinfo!r}")
else:
- self.moment = moment
+ self.moment = timezone.convert_to_utc(moment)
Review Comment:
I just updated the test `test_datetime_trigger_timing` to check if the logic
remains valid with different timezones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
