hussein-awala commented on PR #30558: URL: https://github.com/apache/airflow/pull/30558#issuecomment-1507770774
The method `_ensure_prefixes` was added in #27041 by @dstandish: https://github.com/apache/airflow/blob/058b6ebdd863ff9178007f5750cc4cde4d3c463f/airflow/providers/microsoft/azure/hooks/fileshare.py#L29-L33 I don't think we really need to wait until bumping the provider min airflow version to >= 2.5.0, since we check for the two variables (with and without `extra_...`) in each extra field loading, and with this PR, we will have: - For the new connections, the extra fields will be created without `extra_` prefix -> this should work without any problem - For the connection which have fields with `extra_`, when we update them will have a new field without the `extra_` prefix and another one with `extra_` prefix but with the old value, this old value will not be processed as long as the new one is present in the extra. - For the connection which have fields with `extra_`, without any update, the provider will use the fields with the prefix, and a warning will be logged to prompt the user to update the connection extra fields. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
