[GitHub] [airflow] jedcunningham commented on a diff in pull request #29135: Keyfile dict can be dict not str

2023-01-24 Thread via GitHub
jedcunningham commented on code in PR #29135: URL: https://github.com/apache/airflow/pull/29135#discussion_r1085847354 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -491,7 +494,7 @@ def provide_gcp_credential_file_as_context(self) -> Generator[str | None,

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29135: Keyfile dict can be dict not str

2023-01-24 Thread via GitHub
jedcunningham commented on code in PR #29135: URL: https://github.com/apache/airflow/pull/29135#discussion_r1085734976 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -242,7 +242,10 @@ def get_credentials_and_project_id(self) ->

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29135: Keyfile dict can be dict not str

2023-01-24 Thread via GitHub
jedcunningham commented on code in PR #29135: URL: https://github.com/apache/airflow/pull/29135#discussion_r1085734976 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -242,7 +242,10 @@ def get_credentials_and_project_id(self) ->