[GitHub] [airflow] jedcunningham commented on a diff in pull request #29147: Rename most pod_id usage to pod_name in KubernetesExecutor

2023-04-11 Thread via GitHub
jedcunningham commented on code in PR #29147: URL: https://github.com/apache/airflow/pull/29147#discussion_r1163426106 ## airflow/executors/kubernetes_executor.py: ## @@ -915,8 +919,8 @@ def _adopt_completed_pods(self, kube_client: client.CoreV1Api) -> None: )

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29147: Rename most pod_id usage to pod_name in KubernetesExecutor

2023-04-11 Thread via GitHub
jedcunningham commented on code in PR #29147: URL: https://github.com/apache/airflow/pull/29147#discussion_r1163425051 ## airflow/executors/kubernetes_executor.py: ## @@ -792,28 +793,31 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29147: Rename most pod_id usage to pod_name in KubernetesExecutor

2023-01-25 Thread via GitHub
jedcunningham commented on code in PR #29147: URL: https://github.com/apache/airflow/pull/29147#discussion_r1086833410 ## airflow/executors/kubernetes_executor.py: ## @@ -368,17 +368,17 @@ def delete_pod(self, pod_id: str, namespace: str) -> None: if e.status !=

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29147: Rename most pod_id usage to pod_name in KubernetesExecutor

2023-01-25 Thread via GitHub
jedcunningham commented on code in PR #29147: URL: https://github.com/apache/airflow/pull/29147#discussion_r1086195497 ## airflow/executors/kubernetes_executor.py: ## @@ -792,28 +793,31 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29147: Rename most pod_id usage to pod_name in KubernetesExecutor

2023-01-24 Thread via GitHub
jedcunningham commented on code in PR #29147: URL: https://github.com/apache/airflow/pull/29147#discussion_r1086193863 ## airflow/executors/kubernetes_executor.py: ## @@ -353,12 +353,12 @@ def run_next(self, next_job: KubernetesJobType) -> None: self.run_pod_async(pod,