[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-14 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166348443 ## airflow/jobs/scheduler_job_runner.py: ## @@ -1425,6 +1465,51 @@ def _send_sla_callbacks_to_processor(self, dag: DAG) -> None: )

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-14 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166343231 ## airflow/jobs/scheduler_job_runner.py: ## @@ -1425,6 +1465,51 @@ def _send_sla_callbacks_to_processor(self, dag: DAG) -> None: )

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166109290 ## airflow/jobs/scheduler_job_runner.py: ## @@ -1425,6 +1461,47 @@ def _send_sla_callbacks_to_processor(self, dag: DAG) -> None: )

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166100533 ## airflow/executors/kubernetes_executor.py: ## @@ -865,6 +826,41 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166086367 ## airflow/executors/base_executor.py: ## @@ -376,6 +378,22 @@ def terminate(self): """This method is called when the daemon receives a SIGTERM."""

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166085371 ## airflow/executors/base_executor.py: ## @@ -297,8 +297,10 @@ def change_state(self, key: TaskInstanceKey, state: str, info=None) -> None: """

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1166052103 ## newsfragments/30375.significant.rst: ## @@ -0,0 +1,9 @@ +Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout Review Comment:

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1165739839 ## airflow/executors/celery_executor.py: ## @@ -543,22 +417,28 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-13 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1165711032 ## airflow/configuration.py: ## @@ -236,6 +236,16 @@ class AirflowConfigParser(ConfigParser): ("scheduler", "parsing_cleanup_interval"): ("scheduler",

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-06 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1160269297 ## airflow/jobs/scheduler_job.py: ## @@ -152,6 +152,43 @@ def __init__( self._zombie_threshold_secs = conf.getint("scheduler",

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-06 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1160264990 ## airflow/jobs/scheduler_job.py: ## @@ -152,6 +152,43 @@ def __init__( self._zombie_threshold_secs = conf.getint("scheduler",

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30375: Simplify logic to resolve tasks stuck in queued despite stalled_task_timeout

2023-04-06 Thread via GitHub
jedcunningham commented on code in PR #30375: URL: https://github.com/apache/airflow/pull/30375#discussion_r1160251186 ## airflow/jobs/scheduler_job.py: ## @@ -1408,6 +1443,51 @@ def _send_sla_callbacks_to_processor(self, dag: DAG) -> None: )