jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-898724877
@Sonins, congrats on your first commit! Thanks for the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-897026685
@Sonins, looks like there is a static check failure in
`chart/tests/test_elasticsearch_secret.py`. I'd suggest that you [set up the
pre-commit
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896858088
(I closed/reopened to try and get CI to run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-896230424
> Cool. I think new issue for that will be necessary later.
Yep, we can do this as a follow up .
--
This is an automated message from the Apache Git Service.
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-895341826
> And also, Should default port be 80? As far as i know, Elasticsearch uses
port 9200 as default.
Yeah, we should change it to 9200.
--
This is an automated
jedcunningham commented on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894562815
Hey @Sonins, what I meant was we need to write new tests to cover this
change (well, and the whole elasticsearch secret). The tests in
