john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-1057281265
> better merge it now before it breaks again!
thanks @dstandish !
--
This is an automated message from the Apache Git Service.
To respond to the message, please
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-1054610216
I agree @vincbeck should be the author as he is pushing it to completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-1027125079
> I tihnk this one needs to be rebased. It's 73 commits behind.
Should be up to date now
--
This is an automated message from the Apache Git Service.
To respond to
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-1002267357
> After #20276
> ~is this PR still needed?~
> Using `RedshiftDataHook` can be confusing, isn't it?
> cc @dstandish
It is different. See description in the
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-967357361
> > @ephraimbuddy I don't see other similar operators, such as sagemaker or
glue, using system tests. Are we sure this is necessary for redshift-data?
>
> Agree that
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-963434764
> Another thing that's required here is a system test. That would help us to
verify that the example works as expected.
>
> See
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-962663236
> Is this something taht you are still working on @john-jac ?
Yes it’s still on my list. There were a number of additions requested. Some
I’ve addressed in my
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-949976235
> In that case, to avoid confusion, we should separate this to a different
file e.g `redshift_data.py` just like we have `glue.py`, `glue_crawler.py` and
`glue_catalog.py`.
john-jac commented on pull request #19137:
URL: https://github.com/apache/airflow/pull/19137#issuecomment-949665818
> Why can't we use RedshiftSQLHook or RedshiftHook? Why do we need a new
hook? It's not clear to me.
RedshiftSQLHook extends DbApiHook, whereas RedshiftDataHook is
