jon-evergreen commented on PR #28202:
URL: https://github.com/apache/airflow/pull/28202#issuecomment-1344578092
Also, in case it wasn't clear, I have now checked in the updated `sql.pyi`
file
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jon-evergreen commented on PR #28202:
URL: https://github.com/apache/airflow/pull/28202#issuecomment-1344327662
I did install the hooks after the first commit which got bounced. And when
I make changes to the `sql.py` I get this in the pre-commit logs:
```
Check and update
jon-evergreen commented on PR #28202:
URL: https://github.com/apache/airflow/pull/28202#issuecomment-1342547253
Ah, the static checks for BigQuery are failing because there's no longer a
`self.sql` attribute. This suggests to me maybe I should keep `self.sql`
around, and have that be
jon-evergreen commented on PR #28202:
URL: https://github.com/apache/airflow/pull/28202#issuecomment-1342490499
Yes, sorry, I missed those yesterday.
This code took the slightly more complex approach of moving things around
such that the SQL gets generated only in the execute method.
