jplauri commented on PR #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-1250207068
> Please add a test for this
Would you have a chance to revisit this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jplauri commented on PR #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-1193739796
Just to avoid this going stale as I think it could be helpful. @dstandish do
you think some work is still required?
--
This is an automated message from the Apache Git Service.
To res
jplauri commented on PR #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-1133920733
> Please add a test for this
Should this be good to go now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jplauri commented on pull request #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-983930377
@dstandish Not really sure if I got it right - I basically copied from
TestPostgres with only superficial understanding. But intuitively it makes
sense - running `test_mssql_t
jplauri commented on pull request #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-979369199
@dstandish Would you be able to advise me further here, i.e., is there
something more the PR should have? Should we just wait for a review/merge, or
what's the process? I'm in
jplauri commented on pull request #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-970480520
> @jplauri regarding your question about merge vs insert, i think merge is
the right call. That list of issues is pretty ancient now. Merge was
implemented in 2008 and by now,
