[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r350331737 ## File path: airflow/serialization/base_serialization.py ## @@ -22,17 +22,18 @@ import datet

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r350330611 ## File path: airflow/serialization/serialized_dag.py ## @@ -111,26 +95,26 @@ def deserialize_

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r350329196 ## File path: airflow/serialization/base_serialization.py ## @@ -123,6 +122,27 @@ def _is_excl

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349808012 ## File path: airflow/utils/db.py ## @@ -336,8 +336,12 @@ def resetdb(): Clear out the da

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349807337 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the dat

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349807159 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the dat

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349806276 ## File path: airflow/models/baseoperator.py ## @@ -235,29 +234,26 @@ class derived from this

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349806164 ## File path: airflow/models/baseoperator.py ## @@ -26,19 +26,18 @@ import warnings from abc

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r349805433 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the dat

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348673191 ## File path: airflow/models/baseoperator.py ## @@ -834,7 +836,6 @@ def clear(self, C

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r34867 ## File path: airflow/models/dag.py ## @@ -55,9 +55,6 @@ from airflow.utils.sqlalchemy import

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348673030 ## File path: airflow/models/baseoperator.py ## @@ -433,8 +431,7 @@ def __init__(

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348546748 ## File path: airflow/contrib/operators/dynamodb_to_s3.py ## @@ -32,7 +32,7 @@ from boto.comp

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348527882 ## File path: airflow/__init__.py ## @@ -31,6 +31,7 @@ # pylint:disable=wrong-import-position

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348490553 ## File path: CONTRIBUTING.rst ## @@ -509,6 +509,35 @@ You can always skip running the tests b

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348488803 ## File path: .pre-commit-config.yaml ## @@ -190,6 +190,33 @@ repos: files: ^BREEZE.r

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348518234 ## File path: airflow/utils/db.py ## @@ -336,6 +336,8 @@ def resetdb(): Clear out the dat

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348517076 ## File path: airflow/serialization/serialized_dag.py ## @@ -111,27 +95,26 @@ def deserialize_

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348517451 ## File path: airflow/settings.py ## @@ -30,7 +30,7 @@ from sqlalchemy.orm.session import Ses

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348515743 ## File path: airflow/serialization/serialized_baseoperator.py ## @@ -66,34 +66,13 @@ def task

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348513225 ## File path: airflow/serialization/serialization_base.py ## @@ -43,8 +44,8 @@ FAILED = 'seri

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348511325 ## File path: airflow/models/dagbag.py ## @@ -124,7 +123,10 @@ def get_dag(self, dag_id, from_

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348510804 ## File path: airflow/models/dagbag.py ## @@ -124,7 +123,10 @@ def get_dag(self, dag_id, from_

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348494836 ## File path: airflow/models/baseoperator.py ## @@ -26,19 +26,18 @@ import warnings from abc

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348506311 ## File path: airflow/models/baseoperator.py ## @@ -834,7 +836,6 @@ def clear(self, C

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348496616 ## File path: airflow/models/baseoperator.py ## @@ -235,29 +234,26 @@ class derived from this

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348493677 ## File path: airflow/models/__init__.py ## @@ -39,4 +38,5 @@ # Load SQLAlchemy models duri

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348493439 ## File path: airflow/contrib/operators/dynamodb_to_s3.py ## @@ -32,7 +32,7 @@ from boto.comp

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348502363 ## File path: airflow/models/baseoperator.py ## @@ -393,27 +390,28 @@ def __init__(

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348509289 ## File path: airflow/models/dag.py ## @@ -55,9 +55,6 @@ from airflow.utils.sqlalchemy import

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348503407 ## File path: airflow/models/baseoperator.py ## @@ -433,8 +431,7 @@ def __init__(

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348497852 ## File path: airflow/models/baseoperator.py ## @@ -298,7 +294,7 @@ def __init__( end

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348497292 ## File path: airflow/models/baseoperator.py ## @@ -281,7 +277,7 @@ class derived from this on

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348491503 ## File path: UPDATING.md ## @@ -41,6 +41,13 @@ assists users migrating to a new version. #

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348497687 ## File path: airflow/models/baseoperator.py ## @@ -298,7 +294,7 @@ def __init__( end

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348505549 ## File path: airflow/models/baseoperator.py ## @@ -463,6 +460,7 @@ def __rshift__(self, other

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348493381 ## File path: airflow/contrib/operators/dynamodb_to_s3.py ## @@ -32,7 +32,7 @@ from boto.comp

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348501552 ## File path: airflow/models/baseoperator.py ## @@ -381,7 +378,7 @@ def __init__(

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348496016 ## File path: airflow/models/baseoperator.py ## @@ -235,29 +234,26 @@ class derived from this

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348490553 ## File path: CONTRIBUTING.rst ## @@ -509,6 +509,35 @@ You can always skip running the tests b

[GitHub] [airflow] kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables

kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348488803 ## File path: .pre-commit-config.yaml ## @@ -190,6 +190,33 @@ repos: files: ^BREEZE.r