kaxil commented on issue #6473: [AIRFLOW-5819] Update AWSBatchOperator default value URL: https://github.com/apache/airflow/pull/6473#issuecomment-548361496 Can you fix the failing tests too: ``` ====================================================================== 7) FAIL: test_execute_with_failures (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ---------------------------------------------------------------------- Traceback (most recent call last): tests/contrib/operators/test_awsbatch_operator.py line 102 in test_execute_with_failures arrayProperties=None /usr/local/lib/python3.6/unittest/mock.py line 825 in assert_called_once_with return self.assert_called_with(*args, **kwargs) /usr/local/lib/python3.6/unittest/mock.py line 814 in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: Expected call: submit_job(arrayProperties=None, containerOverrides={}, jobDefinition='hello-world', jobName='51455483-c62c-48ac-9b88-53a6a725baa3', jobQueue='queue') Actual call: submit_job(arrayProperties={}, containerOverrides={}, jobDefinition='hello-world', jobName='51455483-c62c-48ac-9b88-53a6a725baa3', jobQueue='queue') -------------------- >> begin captured logging << -------------------- airflow.task.operators: INFO: Running AWS Batch Job - Job definition: hello-world - on queue queue airflow.task.operators: INFO: AWSBatchOperator overrides: {} airflow.task.operators: INFO: AWS Batch Job started: airflow.task.operators: INFO: AWS Batch Job has failed executed --------------------- >> end captured logging << --------------------- ====================================================================== 8) FAIL: test_execute_without_failures (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ---------------------------------------------------------------------- Traceback (most recent call last): /usr/local/lib/python3.6/unittest/mock.py line 1183 in patched return func(*args, **keywargs) tests/contrib/operators/test_awsbatch_operator.py line 81 in test_execute_without_failures arrayProperties=None /usr/local/lib/python3.6/unittest/mock.py line 825 in assert_called_once_with return self.assert_called_with(*args, **kwargs) /usr/local/lib/python3.6/unittest/mock.py line 814 in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: Expected call: submit_job(arrayProperties=None, containerOverrides={}, jobDefinition='hello-world', jobName='51455483-c62c-48ac-9b88-53a6a725baa3', jobQueue='queue') Actual call: submit_job(arrayProperties={}, containerOverrides={}, jobDefinition='hello-world', jobName='51455483-c62c-48ac-9b88-53a6a725baa3', jobQueue='queue') -------------------- >> begin captured logging << -------------------- airflow.task.operators: INFO: Running AWS Batch Job - Job definition: hello-world - on queue queue airflow.task.operators: INFO: AWSBatchOperator overrides: {} airflow.task.operators: INFO: AWS Batch Job started: {'jobName': '51455483-c62c-48ac-9b88-53a6a725baa3', 'jobId': '8ba9d676-4108-4474-9dca-8bbac1da9b19'} airflow.task.operators: INFO: AWS Batch Job has been successfully executed: {'jobName': '51455483-c62c-48ac-9b88-53a6a725baa3', 'jobId': '8ba9d676-4108-4474-9dca-8bbac1da9b19'} --------------------- >> end captured logging << --------------------- ====================================================================== 9) FAIL: test_init (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ---------------------------------------------------------------------- Traceback (most recent call last): tests/contrib/operators/test_awsbatch_operator.py line 56 in test_init self.assertEqual(self.batch.array_properties, None) AssertionError: {} != None ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
