[GitHub] [airflow] kazanzhy commented on pull request #20642: Added Hook for Amazon RDS

2022-02-18 Thread GitBox
kazanzhy commented on pull request #20642: URL: https://github.com/apache/airflow/pull/20642#issuecomment-1045315483 When I run `mypy airflow/providers/amazon/aws/hooks` on `main` I'm getting only two errors. But when I'm adding `boto3-stubs[rds]` to `settings.py` and rebuild the image,

[GitHub] [airflow] kazanzhy commented on pull request #20642: Added Hook for Amazon RDS

2022-01-31 Thread GitBox
kazanzhy commented on pull request #20642: URL: https://github.com/apache/airflow/pull/20642#issuecomment-1026281475 I've rebased to the latest main but seems something wrong with checks. I'm getting 213 errors on the latest main after I run this command in the breeze shell `mypy

[GitHub] [airflow] kazanzhy commented on pull request #20642: Added Hook for Amazon RDS

2022-01-30 Thread GitBox
kazanzhy commented on pull request #20642: URL: https://github.com/apache/airflow/pull/20642#issuecomment-1025234954 @potiuk That's very interesting. A few days ago the same code passed all checks. That's a very interesting issue because I'm running locally `./breeze static-chec

[GitHub] [airflow] kazanzhy commented on pull request #20642: Added Hook for Amazon RDS

2022-01-04 Thread GitBox
kazanzhy commented on pull request #20642: URL: https://github.com/apache/airflow/pull/20642#issuecomment-1005276831 A lot of thanks that clarifying the way to implementation @dstandish The solutions below don't work and it's expected ``` from typing import Type from bo