[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407462128 * Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. I am sorry I wasn't clear. I meant what should I do about the test that

[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407445003 @potiuk what should I do next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-25 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1404166547 I finally figured out the type error and fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-25 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1404081234 I needed to change the method _format_action to _rich_format_action to work with rich_argparse. Now I get an output format similar to before ![Screenshot 2023-01-25

[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-24 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1402667103 I don't know if there is a specific tool that you use for performance testing, I ran "time airflow cheat-sheet" a bunch of times without the change and with the change and I got this: