[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-22 Thread via GitHub
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1115118926 ## airflow/providers/telegram/provider.yaml: ## @@ -39,7 +40,7 @@ dependencies: # The telegram bot 20.0.0 is not yet compatible with our provider as

[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-01-16 Thread GitBox
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1071365785 ## airflow/providers/telegram/CHANGELOG.rst: ## @@ -24,6 +24,19 @@ Changelog - +4.0.0 +. + +Breaking changes + + +* This release

[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-01-16 Thread GitBox
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1071210603 ## tests/providers/telegram/hooks/test_telegram.py: ## @@ -128,7 +128,7 @@ def test_should_send_message_if_chat_id_is_provided_through_constructor(self, mo

[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-01-15 Thread GitBox
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1070914304 ## airflow/providers/telegram/hooks/telegram.py: ## @@ -137,5 +139,5 @@ def send_message(self, api_params: dict) -> None: if kwargs["chat_id"] is None:

[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-01-15 Thread GitBox
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1070729605 ## tests/providers/telegram/hooks/test_telegram.py: ## @@ -72,28 +71,31 @@ def test_should_raise_exception_if_conn_id_doesnt_contain_token(self):

[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-01-15 Thread GitBox
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1070729407 ## airflow/providers/telegram/hooks/telegram.py: ## @@ -118,15 +118,15 @@ def __get_chat_id(self, chat_id: str | None, telegram_conn_id: str | None) -> st