[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337092181 ## File path: airflow/gcp/utils/credentials_provider.py ## @@ -0,0 +1,185 @@ +# -*- coding:

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337092489 ## File path: airflow/gcp/utils/credentials_provider.py ## @@ -0,0 +1,185 @@ +# -*- coding:

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337106103 ## File path: tests/gcp/utils/base_gcp_system_test_case.py ## @@ -241,11 +238,9 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337092372 ## File path: airflow/gcp/utils/credentials_provider.py ## @@ -0,0 +1,185 @@ +# -*- coding:

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337103965 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -0,0 +1,184 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337100168 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -0,0 +1,184 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337100073 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -0,0 +1,184 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337093571 ## File path: tests/gcp/operators/test_cloud_sql_system.py ## @@ -17,42 +17,34 @@ # specific

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r337099976 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -0,0 +1,184 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r336888129 ## File path: tests/gcp/operators/test_cloud_sql_system.py ## @@ -17,42 +17,34 @@ # specific

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-21 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r336887683 ## File path: airflow/utils/log/colored_log.py ## @@ -30,7 +30,7 @@ ARGS = {"attrs":

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333658530 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333645166 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333645762 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333645166 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333601897 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333476751 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333479290 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333479014 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333478671 ## File path: airflow/gcp/hooks/base.py ## @@ -294,6 +295,26 @@ def wrapper(self:

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333477798 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

2019-10-10 Thread GitBox
mik-laj commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests URL: https://github.com/apache/airflow/pull/6299#discussion_r333476751 ## File path: airflow/gcp/hooks/base.py ## @@ -323,8 +341,63 @@ def