[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-24 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-475943831 Unit tests are needed only. Example: https://github.com/apache/airflow/blob/master/tests/contrib/ope

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-23 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-475924128 I have a suggestion. To add it to your repository execute a command: ```bash curl https://termbin.com/w

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-17 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-473732802 I really like the solution with the tenacity library. ;-) Awesome! -

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-13 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-472677494 This is not enough reason to change these rules.I think that the code should be rewritten. We have rules th

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-11 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-471752939 @dchaplinsky https://airflow.apache.org/concepts.html#trigger-rules

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-11 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-471742353 @dchaplinsky All elements from this module should be treated as public, because we want to have automaticall

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-11 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-471619013 I am now working on a new look for the documents from this section. I will be happy if you follow my new str

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-11 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-471615851 @dchaplinsky Look at: https://github.com/apache/airflow/blob/master/docs/conf.py#L39-L91 You only need to