[GitHub] [airflow] milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-06-20 Thread GitBox
milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#issuecomment-504109166 @feng-tao I have resolved the conflicts and now CI is green. This is

[GitHub] [airflow] milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-06-19 Thread GitBox
milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#issuecomment-503659981 @ashb This PR only changes how user configure the default pool. This

[GitHub] [airflow] milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-06-18 Thread GitBox
milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#issuecomment-503411773 Ready for another look @ashb @feng-tao @XD-DENG This is an automated

[GitHub] [airflow] milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-06-14 Thread GitBox
milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#issuecomment-501992207 I think it doesn't hurt to restrict the field to nonnull This is an

[GitHub] [airflow] milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-06-12 Thread GitBox
milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#issuecomment-501536629 PTAL @ashb @feng-tao @potiuk This is an automated message from the

[GitHub] [airflow] milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-06-04 Thread GitBox
milton0825 commented on issue #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#issuecomment-498819044 @ashb thanks for the review. This PR is ready for another look. This