[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-08-30 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1311167222 ## airflow/jobs/scheduler_job_runner.py: ## @@ -86,6 +86,10 @@ DR = DagRun DM = DagModel +# type alias for task concurrency map, +# (dag_id, run_id, task_group_id

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-27 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1276444608 ## airflow/decorators/task_group.py: ## @@ -184,6 +184,7 @@ def task_group( ui_color: str = "CornflowerBlue", ui_fgcolor: str = "#000", add_suffix_on_c

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-27 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1276436829 ## tests/jobs/test_scheduler_job.py: ## @@ -1137,6 +1138,142 @@ def test_find_executable_task_instances_max_active_tis_per_dag(self, dag_maker): assert 1 ==

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-17 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r126497 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-17 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r126497 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264891286 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r126497 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264891286 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264891286 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264883562 ## airflow/serialization/serialized_objects.py: ## @@ -1401,6 +1401,8 @@ def serialize_task_group(cls, task_group: TaskGroup) -> dict[str, Any] | None:

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262265208 ## airflow/models/taskinstance.py: ## @@ -2580,6 +2580,31 @@ def get_num_running_task_instances(self, session: Session, same_dagrun=False) -> )

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262423525 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262282293 ## airflow/jobs/scheduler_job_runner.py: ## @@ -513,34 +567,30 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session) -

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262265208 ## airflow/models/taskinstance.py: ## @@ -2580,6 +2580,31 @@ def get_num_running_task_instances(self, session: Session, same_dagrun=False) -> )

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262228890 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262228353 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262209457 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262175609 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .where

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r128373 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255443742 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255443742 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255443742 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255443742 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255443742 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255386212 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255386212 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255361661 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

2023-07-07 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255358565 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my

[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

2023-07-04 Thread via GitHub
mis98zb commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1252501760 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when my