nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-591092356
That was a big cycle removal. As discussed above, I don't know any other
"session" in airflow so the
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-591091572
Yeah, so long that I at first edited your comment instead of reply :D
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-591091208
>And how did this reduce cyclic imports when utils.db imports the new file
still?!
That is not a problem.
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-569442066
> I restarted the latest build - it was failing with cassandra problem
It's 3 time at this build. It makes
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-569430073
> I rebased before opening a PR because I saw merge conflict ✅
> But i see some changes that are unrelated
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-569427448
Regarding backward compatibility - it works only for `provide_session`,
should I import `create_session` in
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create
session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-569427350
> But I think it needs rebase now after I merged #6936 as it contains some
unrelated changes.
>
I
