nullhack commented on a change in pull request #9179:
URL: https://github.com/apache/airflow/pull/9179#discussion_r436736580
##########
File path: airflow/utils/dates.py
##########
@@ -24,6 +24,7 @@
from airflow.utils import timezone
cron_presets = {
+ '@minutely': '* * * * *',
Review comment:
If I understood correctly the word exists, but is archaic/has double
meaning [[1]](https://www.thefreedictionary.com/minutely)
[[2]](https://www.merriam-webster.com/dictionary/minutely)
[[3]](https://www.dictionary.com/browse/minutely?s=t)
If this is the case, I don't think double meaning is a problem here and the
word just fits nice with the rest (but English is not my first language, so
I'll leave the debate to natives)
I can just close the PR, but personally I think some preset for minutes is
missing. It's not about the size either, It is easier to visually find on the
UI, so I would not mind having a bigger string that describes It.
Would other strings be considered ?
`@every_minute`, `@all_minutes`, `@minutes`
##########
File path: airflow/utils/dates.py
##########
@@ -24,6 +24,7 @@
from airflow.utils import timezone
cron_presets = {
+ '@minutely': '* * * * *',
Review comment:
In my particular case, some REST requests doing routine checks. Not part
of any heavy process. We haven't reach the point of taking minutes to
schedule/run tasks yet, only about 50 DAGs and maximum around 20 tasks, most of
It running daily.
##########
File path: airflow/utils/dates.py
##########
@@ -24,6 +24,7 @@
from airflow.utils import timezone
cron_presets = {
+ '@minutely': '* * * * *',
Review comment:
In my particular case, some REST requests doing routine checks. Not part
of any heavy process. We haven't reach the point of taking minutes to
schedule/run tasks yet, only about 50 DAGs and maximum around 20 tasks per DAG,
most of It running daily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
