o-nikolas commented on code in PR #24688: URL: https://github.com/apache/airflow/pull/24688#discussion_r907888822
########## .pre-commit-config.yaml: ########## @@ -19,6 +19,7 @@ default_stages: [commit, push] default_language_version: # force all unspecified python hooks to run python3 python: python3 + node: 16.14.2 Review Comment: I don't have as much context, but I'm curious: what's the reason to go with 16.14.2? It looks like 17 has basically the same support for the same set of platforms/architectures ([source](https://github.com/nodejs/node/blob/v17.x/BUILDING.md#platform-list)). v18 is where the troubles seems to start from what I can tell by the docs and the comments in the linked Githu Issue ([source](https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
