[GitHub] [airflow] o-nikolas commented on pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-04-14 Thread via GitHub
o-nikolas commented on PR #28338: URL: https://github.com/apache/airflow/pull/28338#issuecomment-1508900573 congrats on the first contribution @mrichman!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] o-nikolas commented on pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-04-13 Thread via GitHub
o-nikolas commented on PR #28338: URL: https://github.com/apache/airflow/pull/28338#issuecomment-1507883671 Just approved another build on the latest changes! :crossed_fingers: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] o-nikolas commented on pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-03-30 Thread via GitHub
o-nikolas commented on PR #28338: URL: https://github.com/apache/airflow/pull/28338#issuecomment-1490954958 > Is there a way to patch the call to `get_item()` in my sensor so that it returns a canned response? Absolutely, you could even just mock the conn to return a Mocked Table

[GitHub] [airflow] o-nikolas commented on pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-03-30 Thread via GitHub
o-nikolas commented on PR #28338: URL: https://github.com/apache/airflow/pull/28338#issuecomment-1490667768 > > > It's failing on the last line of the test `assert sensor.poke(None)`. What am I doing wrong here? > > > > > > Can you include some more context (traceback, logs, etc)

[GitHub] [airflow] o-nikolas commented on pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-03-29 Thread via GitHub
o-nikolas commented on PR #28338: URL: https://github.com/apache/airflow/pull/28338#issuecomment-1489353144 > It's failing on the last line of the test `assert sensor.poke(None)`. What am I doing wrong here? Can you include some more context (traceback, logs, etc) for the failure

[GitHub] [airflow] o-nikolas commented on pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-01-24 Thread via GitHub
o-nikolas commented on PR #28338: URL: https://github.com/apache/airflow/pull/28338#issuecomment-1403128044 Hey @mrichman, Any plans to make more progress on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub