[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-02-13 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1038010070 Hello @potiuk, I hope you are doing well :smile: The CI has failed on `Tests / Helm Chart; KubernetesExecutor` (1 test didn't pass) but it does not seem

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-02-13 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1038010070 Hello @potiuk, I hope you are doing well :smile: The CI has failed on `Tests / Helm Chart; KubernetesExecutor` (1 test didn't pass) but it does not seem

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-02-12 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1037129646 > Unfortunately - static checks you will have to fix by pushing new code I am afraid :smile: @potiuk that new docstring-param hook got me I guess :joy: I

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-02-10 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1035619367 @potiuk Yes of course, I just rebased the branch. Nice I didn't know we could do that directly from the GitHub interface :+1: -- This is an automated message from th

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-02-10 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1035458565 Hi @eladkal and @potiuk, It has been a couple of week since last activity on this PR. I would like to follow up, I think it's ready to merge. Is there any

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-01-28 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1024592494 @mik-laj The PR is ready if you want to take a look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-01-20 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1017958438 Just tested it, normally everything is working fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-01-16 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1013950852 Thank you @aaltay, I managed to make it work (go pipeline on dataflow), the issue was on my end caused by a wrong configuration. I have rebased my branch, and te

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2022-01-09 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-1008423832 I just rebased on main and updated the PR following your reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2021-12-20 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-997892069 @subkanthi Thank you for pointing. There were 2 definitions of the same `_jobs` attribute, I removed one in my branch and `main` removed the other :face_with_spiral_eye

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2021-12-17 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-996922608 Just amended for fix static checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov