[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-09-21 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1333867561 ## airflow/models/taskinstance.py: ## @@ -190,23 +192,24 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-09-21 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1333867561 ## airflow/models/taskinstance.py: ## @@ -190,23 +192,24 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-31 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1311295636 ## airflow/models/taskinstance.py: ## @@ -1978,257 +2668,88 @@ def handle_failure( task: BaseOperator | None = None try: -if

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-31 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1311282316 ## airflow/models/taskinstance.py: ## @@ -787,6 +788,38 @@ def error(self, session: Session = NEW_SESSION) -> None: session.merge(self)

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-31 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1311272910 ## airflow/models/taskinstance.py: ## @@ -374,6 +377,780 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance,

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-31 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1311270704 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance,

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308997364 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308462937 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance,

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308444079 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308443226 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance,

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308441589 ## airflow/models/dagrun.py: ## @@ -519,27 +566,44 @@ def get_dag(self) -> DAG: return self.dag +@staticmethod +@internal_api_call

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308440661 ## airflow/models/dagrun.py: ## @@ -501,11 +523,36 @@ def get_task_instance( """ Return the task instance specified by task_id for this dag run. +

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308436541 ## airflow/models/dag.py: ## @@ -1373,6 +1374,40 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval =

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308430456 ## airflow/models/dag.py: ## @@ -1373,6 +1374,40 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval =

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308393441 ## airflow/models/dag.py: ## @@ -1373,6 +1374,40 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval =

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308392023 ## airflow/models/dag.py: ## @@ -1373,6 +1374,40 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval =

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308388311 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308386268 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308386268 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308384060 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval =

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308384060 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval =