[GitHub] [airflow] potiuk commented on a diff in pull request #33837: Refactor unneeded 'continue' jumps in models

2023-09-12 Thread via GitHub
potiuk commented on code in PR #33837: URL: https://github.com/apache/airflow/pull/33837#discussion_r1323536503 ## airflow/models/mappedoperator.py: ## @@ -90,31 +90,21 @@ def validate_mapping_kwargs(op: type[BaseOperator], func: ValidationSource, valu # use a dict so orde

[GitHub] [airflow] potiuk commented on a diff in pull request #33837: Refactor unneeded 'continue' jumps in models

2023-09-04 Thread via GitHub
potiuk commented on code in PR #33837: URL: https://github.com/apache/airflow/pull/33837#discussion_r1314704364 ## airflow/models/mappedoperator.py: ## @@ -97,15 +97,11 @@ def validate_mapping_kwargs(op: type[BaseOperator], func: ValidationSource, valu continue

[GitHub] [airflow] potiuk commented on a diff in pull request #33837: Refactor unneeded 'continue' jumps in models

2023-09-03 Thread via GitHub
potiuk commented on code in PR #33837: URL: https://github.com/apache/airflow/pull/33837#discussion_r1314289102 ## airflow/models/taskinstance.py: ## @@ -2966,12 +2966,9 @@ def as_dict(self): stacklevel=2, ) new_dict = dict(self.__dict__) -