potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-531981855
This is an automated message from the Apache Git Service.
To respond
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-531610072
Hey @dimberman :)?
This is an automated message from the Apache Git
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-530584350
It would be great to get this merged before the workshop in Guadalahara :)
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-530176182
Hey @dimberman -> it's still big but it adds really nice feature to
pre-commits now. It's fully interactive now and when you need to
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-529195119
@mik-laj -> that also addresses your recent questions about rebuilding the
images when you run pre-commit manually. I thought this change
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-529194981
Hey @dimberman - I moved out the dumb-init change, and I tried to split it
even further, but it seem what's left is totally related. I
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-527465162
@dimberman . You are totally right! It started from interactivity but I
added a number of other small fixes along the way and now it's
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-527160950
This one is more difficult/longer to review but I think it might help a lot
with adoption and regular use of pre-commit. I myself started
potiuk commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976#issuecomment-526963873
This one is really useful if you have pre-commit installed and use it.
It integrates well with breeze not only wit pre-commits -
