potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-561206944
Thanks @kaxil @ashb and others :). Merged finally.
This
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-561157463
And @ashb -> the "UPDATING.md" I think there was no warning as it was not
possible to detect this way of importing. So I
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-561156448
Rebased with latest master and pushed all changes.
This
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560527624
I think NOW I resolved everything that needs to be resolved in this commit
(some more commits are following), I let Travi
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560518806
> Still a few unrelated files changed.
>
> Also we've got inconsistent imports airflow.configuration import conf vs
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560079968
@ashb-> I applied all the comments and I am now splitting-off the unrelated
changes. So expect a number of separate PRs
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560028159
@ashb - i fixed all the changes except splitting out the unrelated changes
(they will require rebasing/squashing the chan
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560017527
> Thank you very much - I ask because I've used git bisect a couple of times
over the last few weeks on Airflow to track
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560017256
> Is this going to make it slower -- i.e. does this genrate a list of keys
and then do a list search for the key vs just
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-560014934
> It also seems that about 2/3 of the files have change s unrelated to
removing cyclic imports!
>
> I am a strong
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-559820954
We have still all checks passed :)
This is an automated
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-559453527
@ashb @feluelle @mik-laj : > cannot wait to merge it (I hope no more
conflicts will appear)
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-559274559
I think this is the last set of fixups @feluelle @ashb .
---
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-559273232
> > I will add -> Nones to all the changed classes with no return value
>
> Doesn't mypy infer that automatically?
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-559247723
@feluelle ! indeed I think we need it. And I will add another fixup in a
moment:
- I found that I can add few more t
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558990446
Hey @kaxil @ashb @feluelle @mik-laj -> I have just pushed a rebased version
with all the fixes from conversation above, r
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558527405
Hey @kaxil -> wait for the next push. I am fixing a lot of those comments
and I have all the t
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558068379
I think I have 3 tests in Celery Executor to go. Interesting thing - I think
I managed to repr
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558013576
Hey @ashb @kaxil @bolkedebruin @mik-laj -> can you please take a look at
this one and see if y
19 matches
Mail list logo
