[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-893590266 It's all complete from my side :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-893561416 I'd love to merge it in to get the latest tests of merged v2-1-tests @ashb -> going for a week of vacations tomorrow, I hope GitHub will solve Packages problems as well till

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-893548359 All looks good - some temporary errors only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-892604803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-04 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-892682195 I split-off all not-relevant changes @ashb . The remaining changes concern only the convention name changes. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-04 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-892604803 > There are more changes in here than just chaning from `-` to `/` which makes it very hard to review. No problem I can split it. -- This is an automated message from

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-03 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-891808959 Yeah. I also run all the scenarios in my own repos 1) 'main' from my own repo 2) "main' from a completely new repo (to test builds in forks of our users) 3) PR from another

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-02 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-891174438 FYI I cherry-picked all the changes (including setup.* changes required for providers to v2-1-test), I also pushed and configured all v2-1-test/* images to ghcr.io. I also

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-02 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-890997375 I'd love to merge that one- it has some, significant optimisations and I could also prepare v2-1 branch for 2.1.3 - to get constraints in and release (I will start working on

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-01 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-89058 All test are passing now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-01 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-890577269 Hey @ashb @jhtimmins @kaxil - I have tested all the cases and implemented backwards-compatibility for current opened PRS as well as made the PR works with current `main`

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-07-31 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-890394139 I am still testing it but it looks good. We needed to change convention due to https://issues.apache.org/jira/browse/INFRA-22124 problems with 2.1 but I found out that this is