[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-19 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901925573 No SQLAlchemy internals needed ;). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-19 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901925105 OK. I think I addressed it it in #17729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-18 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901121618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-18 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901126556 Alternatively we could simply check at migrate and throw an exception "you are using utf8mb4, please set this collation_for_ids_to ...". -- This is an automated message from

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-18 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901122657 Do you feel you know intricacies of sqlachemy (including any migration, detection of all the cases when it is needed) etc. to do it automatcally :D ? -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-18 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901121618 Well agree this has been tactical only @uranusjr And we actually HAVE a fix but it is purely manual configuration one and it likely could be improved in terms of "applie