potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-995866427
As discussed today, good startm one thing - it shoudl rather be quite
different in terms of "global" variables. It's better to have a common way to
build a structure, where we
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-996910053
> I am trying to implement running this command via python with build_args
in this code as BuildParams(dataclass). Am i going in right direction?
Oh yeah. That's the beas
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-997374726
> Is this the right way to find version or is there any better way than this?
Yeah. This is the right one. There are few things that are important:
1) We will alway
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-997428940
Captured it here: https://github.com/apache/airflow/pull/20407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-997429404
BTW. looked at the code, it's definitely going in the right direction !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-997861621
> Is this logical order right? Do I have to consider reading from cache
`.build` directory in this task or is it a separate task to read from `.build`
cache directory?
Y
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1000143943
> @potiuk Could you point me to the code logic in current Breeze where the
above logic is happening?
Answered in slack :)
--
This is an automated message from the
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1000228288
I think it's good to keep the values as python constant lists simply. It
will be easier to import and use them in multiple places.
--
This is an automated message from the A
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1001551173
> Do you think we need to give 3 different flags to support different types
of cache? Or can we pass single option `--build-cache` and keep `local, pulled,
none` as different
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1002046623
Goes definitely in the right direction! And you are slowly cracking the most
complex part of it, so kudos for getting as far as you did so far :).
--
This is an automated
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1002047047
Later on we should add some tests, but I think it would be great to get
those comments sorted out first and then we can discuss writing tests!
--
This is an automated messa
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1003427283
Mark it as "ready for review". I wil review and likely merge (We've reviewed
it quite a number of times) and I think we will merge it without tests and i
will open a small PR
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1003430754
Just a few comments - I run it ! works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1004222731
Loooks very, very close @bowrna - just two comments left, I can merge and
then I can add test case example
--
This is an automated message from the Apache Git Service.
To re
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1005587584
Ah @Bowrna - one small thing - failing static check :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1005935016
:tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada:
:tada: :tada: :tada: :tada: :tada:
--
This is an automated message from the Apache Git Service.
16 matches
Mail list logo
