potiuk commented on PR #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1128030626
> thanks @potiuk i definitely love to learn more about it. will keep you
posted.
The typing in #23716 would definitely make it easier :D. I've learned quite
a lot while adding it
potiuk commented on PR #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1126734552
If you want @pingzh you can try to learn it too, and come up with a good
solution - maybe we can eventually compare ours and choose the better one.
--
This is an automated message
potiuk commented on PR #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1126731650
Yes. I looked at it already and I could confirm that `conf.as_dict()` will
work wrongly in this case (and this is the root cause). Currently when you run
conf.as_dict(), the "database"
potiuk commented on pull request #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1086160077
Not good yet. I recommend to install pre-commit and run it locally :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
potiuk commented on pull request #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1085776494
LGTM. Though static + tests need fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on pull request #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1082016809
This one needs rebase I am afraiid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
potiuk commented on pull request #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1079959544
Need rebase unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on pull request #22284:
URL: https://github.com/apache/airflow/pull/22284#issuecomment-1067952521
This one will need much more. It's not enough to move the sections. And
(unless I missed) the change should handle deprecation - this is a very
intrusive change and whoever
