[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165294233 > Hmm, I was under the impression `breeze tests` also needs this, but apparently it does not and “correctly” picks up the AMD-based image. This leads me to think maybe we are doing somet

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165298700 BTW. Initially the idea was that you'd only ever need to "run" stuff on the platform you have - so all the "execution" shoudl by defaiult only be possible on the local platform of yours.

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165299635 but I might want to explore "fixing" the build status to be per image + platform combination. This seems like a useful thing to have. -- This is an automated message from the Apache Gi

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165301363 (or you might want to look at it if you want - I can take a look and point out to where they shoudl be changed @uranusjr ). might be good learning experience :D -- This is an automate

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165602817 Ah yeah. This might also be handy when it comes to running tests on ARM in CI when we convert our CI to use the new breeze for testing (that one is still pending). but if it's on

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165603782 Tests run docker-compose under the hoood. You can run it with `--dry-run` and see the command and then it's easy to copy&paste manully after manually correcting the compose file. This is