[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-06-27 Thread via GitHub
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1609376972 Closing in favour of https://github.com/apache/airflow/pull/32181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-19 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1397718391 Still thinking on it :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1378094682 And yes I am just afraid that we **might** break things for some users - so far I understood that https://github.com/apache/airflow/issues/27545 effectively means that it was really diff

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1378085890 I think this is one of those cases that we really balloon a matrix of tests for very little reason. Seems that we alrady have a number of tests - now failing) where both are set

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1376885202 I personally think it is a bugfix (because it does not work anyway :) ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1376884606 We had a lot of discussions about it with @jedcunningham in related issues and some time ago I wrote the article describing in detail why git-sync and networked persistence do not play a