[GitHub] [airflow] potiuk commented on pull request #28968: Required Param requires None to be explicitly passed as default

2023-02-19 Thread via GitHub
potiuk commented on PR #28968: URL: https://github.com/apache/airflow/pull/28968#issuecomment-1436057533 > @potiuk @aamster following up on my last comment I do not know by heart - I would have to go to details, and I think it's a good exercise to do if you want to make sure the fix w

[GitHub] [airflow] potiuk commented on pull request #28968: Required Param requires None to be explicitly passed as default

2023-01-18 Thread GitBox
potiuk commented on PR #28968: URL: https://github.com/apache/airflow/pull/28968#issuecomment-1386764399 @aamster maybe you can provide some examples of what you think should happen here as the original author of the issue? -- This is an automated message from the Apache Git Service. To r

[GitHub] [airflow] potiuk commented on pull request #28968: Required Param requires None to be explicitly passed as default

2023-01-16 Thread GitBox
potiuk commented on PR #28968: URL: https://github.com/apache/airflow/pull/28968#issuecomment-1383985093 I think this is more than just a small change - the unit tests have to be updated (and added) to cover all cases and I am not sure yet - without looking- what exactly was wrong and how