[GitHub] [airflow] potiuk commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
potiuk commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407581892 > * Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. > > I am sorry I wasn't clear. I meant what should I do about the test

[GitHub] [airflow] potiuk commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
potiuk commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407459585 > @potiuk what should I do next? Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. I just run the tests. Let's see. If you see

[GitHub] [airflow] potiuk commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-24 Thread via GitHub
potiuk commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1403113821 I think performance in this case is very little impacted. The Click change was much more of the problem because click works with python-decorated methods and it has natural tendency to

[GitHub] [airflow] potiuk commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-24 Thread via GitHub
potiuk commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1403113028 Looks cool. You need to rebase, and fix the static checks and CLI tests (the SSM test errors will likely go away after rebase - it was broken main I think). -- This is an automated