potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1450811879
@BasPH Also one more case why having example_dags as "executable" and
separate python file here: https://github.com/apache/airflow/pull/28325
Our example dags are actually
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1438506435
> We should separate purposes and store code for docs separate from tests,
i.e. in the /docs folder. Since that would be a bigger change, happy to close
this PR for now and use it to
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1412956934
Oh yes - I absolutely agree example dags should not be loaded by
default.This is even one of the reasons why in Breeze it is disabled by
default. And if anything I would argue for
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1411034438
Exactly same effect, example is runnable with `--load-example-dags` flag in
start-airflow. No code duplication.
--
This is an automated message from the Apache Git Service.
To respond
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1411031392
> I suggest showing reproducible examples. The current example for the
PythonSensor is not easily reproducible because it doesn't show imports.
Yes I understand that.
What
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1410355082
Very nice.
Just a question - should not we make it back into the example_sensors.py and
include from there? I think the big benefit of include_examples is that the
documentaion
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1410354345
Very nice.
Just a question - should not we make it back into the example_sensors.py and
include from there? I think the big benefit of include_examples is that the
documentaion
potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1410353637
Very nice.
Just a question - should not we make it back into the example_sensors.py and
include from there? I think the big benefit of include_examples is that the
doycumentaion
