[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-20 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1644578831 All is good except ARM builds (which I am working on) . Definitely ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-20 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1644367502 I also did one more thing - since we are modifying "providers" documentation quite heavily here, I noticed we had a lot of old/missing/outdated/badly structured documentation (for exampl

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-20 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1643938711 OK. I think this PR should be ready for final review and has a chance to get green. It is already quite small in fact after extracting the other changes from it - and mostly builds on to

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-19 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1642156847 OK. This one is rebased on top of #32669 - so looks big but only last commit counts assuming #32669 will be merged - it is now what remains from the big original PR, all the rest is curr

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-17 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1639333733 I addressed most point (they are coming in the new extracted PR with configuration "consolidation"). Those that are not "resolved" yet I will address is the final one. -- This is an a

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-17 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1638232431 > I like the approach, it definitely will be cleaner to have provider-related config in provider itself. Getting rid of confusing redundancy in default_airflow.cfg is also nice. Y

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-15 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1636987332 BTW. Converted to a draft and extracting parts of it to separate PRs to make it all reviewable and mergable. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-14 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1635952877 Also some docs screenshots: ![Screenshot from 2023-07-14 16-27-17](https://github.com/apache/airflow/assets/595491/0d6a31cd-468f-4fa2-93b1-cf029c7d5bb3) ![image](https:

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-14 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1635926757 Looking forward for comments :). Especially - is that OK to merge that one as a single PR, or would reviewers prefer to split that one into smaller ones? Small sneak-peek of the ou

[GitHub] [airflow] potiuk commented on pull request #32604: Allow configuration to be contributed by providers

2023-07-14 Thread via GitHub
potiuk commented on PR #32604: URL: https://github.com/apache/airflow/pull/32604#issuecomment-1635919217 Some tests will still fail but I wanted to put that one up for review. And if you think that this one is huge, then well, yes it is. But worry not - in case we agree it is too hug