[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631885153 I think maybe it's the right time to raise that as a separate thread on the devlist so that other people can state their opinion as well? I agree with @ashb and @kaxil tha

[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631620756 > > What's the use-case of writing Variables to an external backend? > > Say we are in a migration process to move DAGs from an old airflow cluster to new airflow cluster.

[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631483938 > Of course there is more than one project that does the same thing called Vault. Of course. > > Even with Azure Vault not being granular enough, this feature is still a -

[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631473133 It would be great to have an understanding how much we can rely on granularity being available. But I believe (at least currently) readonly/write access for whole vault is the co

[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631471582 Not in Azure's Vault for example (and I think this it might be one of the most popular in Corporate world): https://docs.microsoft.com/en-us/azure/key-vault/general/secur

[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631438618 @ashb -> Understood. Agree. And I understand the concerns. Ans I agree that if the configuration for Airlfow is going to be managed by the UI (And readonly set fo False), then it

[GitHub] [airflow] potiuk commented on pull request #8889: Support custom Variable implementation

2020-05-20 Thread GitBox
potiuk commented on pull request #8889: URL: https://github.com/apache/airflow/pull/8889#issuecomment-631359757 @milton0825 - see the discussion I started few days ago about Secret Hooks. https://lists.apache.org/thread.html/re2bd54b0682e14fac6c767895311baf411ea10b18685474f7683a2f5%40%3Cdev