[GitHub] [airflow] potiuk edited a comment on pull request #17576: Add pre/post execution hooks

2021-09-09 Thread GitBox
potiuk edited a comment on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-916426991 I think I even discussed it with @malthe that time based decision will be better done based on AIP-39. So I agree @ashb - this is likely not a good use of those

[GitHub] [airflow] potiuk edited a comment on pull request #17576: Add pre/post execution hooks

2021-09-09 Thread GitBox
potiuk edited a comment on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-916426991 I think I even discussed it with @malthe that time based decision will be better done based on AIP-39. So I agree @ashb - this is likely not a good use of those

[GitHub] [airflow] potiuk edited a comment on pull request #17576: Add pre/post execution hooks

2021-09-09 Thread GitBox
potiuk edited a comment on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-916426991 I think I even discussed it with @malthe that time based decision will be better done based on AIP-39. So I agree @ashb - this is likely not a good use of those

[GitHub] [airflow] potiuk edited a comment on pull request #17576: Add pre/post execution hooks

2021-09-09 Thread GitBox
potiuk edited a comment on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-916426991 I think I even discussed it with @malthe that time based decision will be better done based on AIP-39. So I agree @ashb - this is likely not a good use of those

[GitHub] [airflow] potiuk edited a comment on pull request #17576: Add pre/post execution hooks

2021-09-09 Thread GitBox
potiuk edited a comment on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-916379253 One of the good cases is to distinguish between DEV/PROD environments. For example some of the operators could be skipped on DEV environments and you might want

[GitHub] [airflow] potiuk edited a comment on pull request #17576: Add pre/post execution hooks

2021-08-13 Thread GitBox
potiuk edited a comment on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-898261046 Looking at the test, there must be a reason the test it here (not only to annoy the user) and it says explicitly that new fields should not be added, so that makes me