[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r508883308 ## File path: airflow/providers/amazon/aws/operators/sagemaker_base.py ## @@ -97,3 +97,8 @@ def preprocess_config(self): def execute(self, context

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r508883308 ## File path: airflow/providers/amazon/aws/operators/sagemaker_base.py ## @@ -97,3 +97,8 @@ def preprocess_config(self): def execute(self, context

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r508881355 ## File path: airflow/providers/amazon/aws/sensors/cloud_formation.py ## @@ -86,8 +95,10 @@ def poke(self, context): return False r

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505815593 ## File path: airflow/providers/google/cloud/operators/bigquery.py ## @@ -947,9 +947,7 @@ def execute(self, context) -> None: delegate_t

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505812440 ## File path: airflow/providers/google/cloud/hooks/gcs.py ## @@ -260,7 +260,9 @@ def rewrite( destination_bucket.name, # type: ignore[attr-

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505810546 ## File path: airflow/providers/amazon/aws/operators/sagemaker_base.py ## @@ -41,12 +43,11 @@ class SageMakerBaseOperator(BaseOperator): integer_fie

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505808993 ## File path: airflow/providers/amazon/aws/operators/glue.py ## @@ -87,7 +88,7 @@ def __init__( self.s3_bucket = s3_bucket self.iam_rol

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505808378 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -342,26 +356,27 @@ def _execute_datasync_task(self): if not result:

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505808181 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -307,18 +317,22 @@ def _create_datasync_task(self): if not self.task_arn:

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505807619 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -307,18 +317,22 @@ def _create_datasync_task(self): if not self.task_arn:

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505805235 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -165,27 +166,29 @@ def __init__( ) # Others -self.

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505802397 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -278,7 +272,7 @@ def log_stream(self, log_group, stream_name, start_time=0, skip=0):

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505801559 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -309,8 +303,8 @@ def multi_stream_iter(self, log_group, streams, positions=None):

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505800924 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -105,22 +107,14 @@ def secondary_training_status_message(job_description, prev_descr

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505798253 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -105,22 +107,14 @@ def secondary_training_status_message(job_description, prev_descr

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505797410 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -97,14 +97,14 @@ def get_iam_execution_role(self) -> Dict: self.log.error("Fa

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505790657 ## File path: tests/providers/amazon/aws/operators/test_batch.py ## @@ -86,7 +86,7 @@ def test_init(self): self.assertEqual(self.batch.waiters,