[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-10-07 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-937445404 >I believe so far simply no-one else found it really useful or needed. What is the bar to clear here?.. i.e. 5 thumbs up on opening issue doesn't meet it so I'm curious a

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-10-06 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-937445404 >I believe so far simply no-one else found it really useful or needed. What is the bar to clear here?.. i.e. 5 thumbs up on opening issue doesn't meet it so I'm curious a

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-09-28 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-928642301 @kaxil Noticed this keeps getting pushed. Can you provide any additional context? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-09-27 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-928642301 @kaxil Noticed this keeps getting pushed. Can you provide any additional context? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-25 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-786194069 >Not really. We are not planning to add anything to the context any time soon. and even if we do it's the same for dict/field. If someone extends data class with a new field the

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-25 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-786041115 >Yeah. I was expecting exactly this answer :). So summarizing - what you've done now, you created hybrid dataclass and dictionary put together. Now, my goal is to show you what

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-24 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-785517704 >Seems like we end up with ever compiicating interfaces for no benefit other than "newer" approach where we have simpler alternative. I'd argue that the dataclass interfac

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-24 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-785437346 > Let me explain why this would be a breaking change Surely you can map from Dataclass to Dict in "get_current_context()" method (otherwise you'd have to also correct the co

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-24 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-785259895 Ah interesting kaxil thanks to your link I can see where a TypedDict / Dataclass implementation would go https://github.com/apache/airflow/blob/352b970010846eb4168aa7b2e3

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-24 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-785250252 >TypedDict is far more pythonic (Hints are the way how types are usually added in Python) Hints are how dataclasses uses types as well. They aren't enforced at runtime, u

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-23 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-784646194 >Dataclass is not pythonic at all As a counter point [Dacite](https://github.com/konradhalas/dacite) is a python library that shows how dataclasses can be used for somethi