[GitHub] [airflow] rkarish commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-04 Thread GitBox
rkarish commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1371395461 That would be great to get another set of eyes on this. Congratulations on becoming a Committer by the way! Would love for you to do the honors on this one 😄 . -- This is an automate

[GitHub] [airflow] rkarish commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-04 Thread GitBox
rkarish commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1371388933 You're welcome and Happy New Year! I figured you were on vacation, no rush on the review! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] rkarish commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2022-12-17 Thread GitBox
rkarish commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1356656020 Hey Niko, I've submitted some more changes based on the feedback and requests. I reworked the pickling support attribute, switched to using your get executor class helper method, and im

[GitHub] [airflow] rkarish commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2022-12-16 Thread GitBox
rkarish commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1355848046 Thanks for the feedback Niko! I will clean this up and let you know when I am finished. -- This is an automated message from the Apache Git Service. To respond to the message, please